Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add groth16 #1503

Merged
merged 5 commits into from
Sep 13, 2024
Merged

docs: add groth16 #1503

merged 5 commits into from
Sep 13, 2024

Conversation

mattstam
Copy link
Contributor

@mattstam mattstam commented Sep 12, 2024

Mention Groth16 as an alternative to PLONK.


Note that if you generate PLONK proofs on the prover network, you will encounter a fixed overhead of 90 seconds for the STARK -> SNARK wrapping step. We're actively working on reducing this overhead in our next release.
Note that if you generate Groth16 or PLONK proofs on the prover network, you will encounter a fixed overhead of 90 seconds for the STARK -> SNARK wrapping step. We're actively working on reducing this overhead in our next release.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: not sure if this 90 seconds comment is still relevant

Copy link
Member

@ctian1 ctian1 Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's lower than that, and even lower in v3. You should test to be sure

Copy link
Contributor Author

@mattstam mattstam Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to vary between v2 and v3, I just mentioned fix time w/o any specific numbers which seems much more sustainable

@mattstam mattstam marked this pull request as ready for review September 12, 2024 21:32
Copy link

github-actions bot commented Sep 12, 2024

SP1 Performance Test Results

Branch: mattstam/docs-groth16
Commit: 6a775507
Author: mattstam

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.19 5.72 0.15 1m17s
ssz-withdrawals 2757356 16.36 59.46 16.25 2m50s
tendermint 12593597 6.57 153.38 57.81 3m40s

| CPU | 1+, single-core perf matters | 16+, more is better | 32+, more is better |
| Memory | 8GB+, more is better | 32GB+, more if you have more cores | 64GB+ (for PLONK) |
| Memory | 8GB+, more is better | 32GB+, more if you have more cores | 64GB+, more is better |
| Disk | 20GB+ | 20GB+ | 100GB+ (for trusted setup) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need 100 GB for the artifacts, the artifacts are more like 12 GB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Disk is required to install the SP1 zkVM toolchain and to install the trused setup artifacts, if you plan to locally build the PLONK prover.

Furthermore, disk is used to checkpoint the state of the program execution, which is required to generate the proofs.
Disk is required to install the SP1 zkVM toolchain and to install the trused setup artifacts, if you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "circuit artifacts" instead of rusted setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@mattstam mattstam merged commit 4791740 into dev Sep 13, 2024
10 checks passed
@mattstam mattstam deleted the mattstam/docs-groth16 branch September 13, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants