fix: multi_scalar_multiplication
#1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
|
SP1 Performance Test Results Branch: ratan/impl-add-assign-fixes
|
tamirhemo
reviewed
Oct 2, 2024
tamirhemo
reviewed
Oct 3, 2024
tamirhemo
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the complete addition for
secp256k1_addusing a newWeierstrassAffinePointtrait that's implemented for secp256k1, bls12-381 and bn254. Easy to extend tosecpr1.multi_scalar_multiplicationandmul_assignto usecomplete_add_assign, which handles all of the potential edge cases.secp256k1_add,bls12381_addandbn254_addthat covers the complete addition cases.