chore: remove individual example workspaces #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: jon/examples_workspace
|
xJonathanLEI
force-pushed
the
jon/examples_workspace
branch
from
1213c75
to
502bdd7
Compare
xJonathanLEI
changed the title
jtguibas
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, examples are not attached to the root workspace. This causes several issues:
In addition, some examples use their own workspace (not even the
./examples/Cargo.tomlworkspace), causing even more duplication, where many examples build the exact same copy of intermediate crates.This PR moves all examples to the root workspace, and adjusts CI workflows to the new project structure. The
examplesjob has been deleted as examples are now already checked by other jobs, thanks to being in the root workspace.