Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: weierstrass_add test #1605

Merged
merged 4 commits into from
Oct 4, 2024
Merged

fix: weierstrass_add test #1605

merged 4 commits into from
Oct 4, 2024

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Oct 4, 2024 •
edited
Loading

  • Use is_infinity in the weierstrass_add test, as limbs_ref fails when the limbs are infinity.
  • Update the Weierstrass implementation for BN254 and BLS12-381 to point to the Weierstrass implementation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: ratan/fix-tests
Commit: db86a327
Author: ratankaliani

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.17 4.47 0.43 27s ✅
ssz-withdrawals 2757356 11.91 62.16 34.77 1m20s ✅
tendermint 12593597 5.61 168.45 101.44 2m6s ✅

@ratankaliani ratankaliani mentioned this pull request Oct 4, 2024
Merged
@ratankaliani ratankaliani merged commit 75fa677 into tamir/v1.3.0-rc2 Oct 4, 2024
23 checks passed
@ratankaliani ratankaliani deleted the ratan/fix-tests branch October 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ratankaliani