Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove stdin from SP1ProofWithPublicValues #1714

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix: remove stdin from SP1ProofWithPublicValues #1714

merged 3 commits into from
Oct 30, 2024

Conversation

jtguibas
Copy link
Contributor

@jtguibas jtguibas commented Oct 30, 2024 •
edited
Loading

  • Removes stdin field from SP1ProofWithPublicValues.
  • Removes #[cfg(debug_assertions)] from self.log in the executor.

@jtguibas jtguibas changed the base branch from dev to main October 30, 2024 17:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: john/remove-stdin
Commit: f976e454
Author: jtguibas

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 2.76 0.45 25s ✅
ssz-withdrawals 2757356 10.54 119.05 38.76 1m11s ✅
tendermint 12593597 5.47 238.51 106.69 2m0s ✅

@jtguibas jtguibas merged commit 4451903 into main Oct 30, 2024
18 of 19 checks passed
@jtguibas jtguibas deleted the john/remove-stdin branch October 30, 2024 18:40
yuwen01 added a commit that referenced this pull request Nov 6, 2024
@yuwen01
Revert "fix: remove stdin from SP1ProofWithPublicValues (#1714)"
ee0d541 
This reverts commit 4451903.
@yuwen01 yuwen01 mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctian1 ctian1 ctian1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtguibas @ctian1