Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add MSRV of 1.79 #1736

Merged
merged 3 commits into from
Nov 7, 2024
Merged

chore: add MSRV of 1.79 #1736

merged 3 commits into from
Nov 7, 2024

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Nov 1, 2024 •
edited
Loading

Users could not compile sp1-core-executor on Rust <1.78 because of this feature https://blog.rust-lang.org/2024/06/13/Rust-1.79.0.html#extending-automatic-temporary-lifetime-extension.

@yuwen01
Copy link
Contributor

yuwen01 commented Nov 2, 2024

wait i thought the msrv was 1.81

@ratankaliani
Copy link
Member Author

@yuwen01 Our Rust toolchain has a maximum supported Rust version of 1.81

Because of our use of this feature in sp1-core-executor, we need to set the minimum rust version of our crate to 1.79, otherwise users trying to run sp1-sdk with a lower version will encounter errors like this.

image

ctian1
ctian1 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ctian1 ctian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add rust-version in Cargo.toml too

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

SP1 Performance Test Results

Branch: ratan/msrv
Commit: b97305e
Author: ratankaliani

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 2.89 0.47 24s ✅
ssz-withdrawals 2757356 17.26 128.37 34.77 1m19s ✅
tendermint 12593597 6.67 267.05 100.23 2m8s ✅

@ratankaliani ratankaliani merged commit 80f7cd4 into dev Nov 7, 2024
12 checks passed
@ratankaliani ratankaliani deleted the ratan/msrv branch November 7, 2024 01:04
yuwen01 pushed a commit that referenced this pull request Nov 8, 2024
@ratankaliani @yuwen01
chore: add MSRV of 1.79 (#1736)
edb707d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctian1 ctian1 ctian1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ratankaliani @yuwen01 @ctian1