perf: build time GRO-146 #1739
Merged
perf: build time GRO-146 #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwen01
commented
Nov 1, 2024
|
SP1 Performance Test Results Branch: yuwen/build-exps
|
yuwen01
commented
Nov 4, 2024
| @@ -118,15 +118,6 @@ jobs: | |||
| env: | |||
| CARGO_INCREMENTAL: 1 | |||
|
|
|||
| - name: Add wasm target | |||
There was a problem hiding this comment.
this is no longer a priority since we have the verifier crate
yuwen01
commented
Nov 4, 2024
| @@ -19,7 +19,6 @@ p3-air = { workspace = true } | |||
| p3-baby-bear = { workspace = true } | |||
| p3-challenger = { workspace = true } | |||
| p3-field = { workspace = true } | |||
| p3-blake3 = { workspace = true } | |||
yuwen01
force-pushed
the
yuwen/build-exps
branch
2 times, most recently
from
c2386e5 to
788215b
Compare
yuwen01
force-pushed
the
yuwen/build-exps
branch
from
b5c7632 to
d8edd52
Compare
jtguibas
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of neon feature, since we're not using blake3 hash anymore.
Organize dependencies in Cargo.toml
Tested 6fe72e8 sanity check with network prover