feat: plonk verification with .bytes()
#1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: yuwen/remove-raw-with-checksum
|
yuwen01
changed the title
.bytes()
yuwen01
commented
Nov 5, 2024
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "sp1-verifier" | |||
| description = "Verifier for SP1 Groth16 and Plonk proofs." | |||
| readme = "../../README.md" | |||
| readme = "README.md" | |||
There was a problem hiding this comment.
on one hand, this crate is pretty independent, so by that logic it deserves its own readme.
on the other hand, i'm gonna write some docs in the mdbook, so i can just have this point to the workspace readme maybe?
jtguibas
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies plonk proofs using .bytes() instead of .raw_with_checksum() in the verifier crate.
Preparing for crates.io release with 3.0.0 sdk -- so this PR also updates the verifier readme to point to the package readme instead of the workspace readme, does some better error handling, and adds some comments