Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow should force install just in case #1824

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: workflow should force install just in case #1824

merged 2 commits into from
Nov 26, 2024

Conversation

nhtyy
Copy link
Collaborator

@nhtyy nhtyy commented Nov 26, 2024

Workflows may cache some build artifacts, which may be cargo prove, which can cause this workflow to fail on toolchain install.

Force overwrite any binary, because caching appears to be non deterministic

Copy link
Contributor

github-actions bot commented Nov 26, 2024

SP1 Performance Test Results

Branch: n/fix-workflow
Commit: 4c8bb58
Author: nhtyy

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.17 2.72 0.46 25s
ssz-withdrawals 2757356 17.13 124.17 34.64 1m20s
tendermint 12593597 6.67 263.41 98.85 2m9s

Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhtyy nhtyy merged commit e66f998 into dev Nov 26, 2024
13 of 14 checks passed
@nhtyy nhtyy deleted the n/fix-workflow branch November 26, 2024 23:34
ultraspicy pushed a commit to ultraspicy/sp1 that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants