Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preprocessing api, cleanup, and testing #195

Merged
merged 20 commits into from
Feb 12, 2024
Merged

Conversation

tamirhemo
Copy link
Contributor

No description provided.

@tamirhemo tamirhemo marked this pull request as ready for review February 11, 2024 09:16
@tamirhemo tamirhemo marked this pull request as draft February 11, 2024 09:24
@tamirhemo tamirhemo changed the title feat: preprocessing, cleanup, testing feat: (pk, vk), cleanup, testing Feb 11, 2024
@tamirhemo tamirhemo marked this pull request as ready for review February 11, 2024 20:30
@tamirhemo tamirhemo changed the title feat: (pk, vk), cleanup, testing feat: preprocessing, cleanup, and testing Feb 12, 2024
@tamirhemo tamirhemo changed the title feat: preprocessing, cleanup, and testing feat: preprocessing api, cleanup, and testing Feb 12, 2024
pub struct VerifyingKey<SC: StarkGenericConfig> {
pub commit: Com<SC>,
pub byte_dimensions: Dimensions,
// program_dimensions: Dimensions,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix or add TODO

@tamirhemo tamirhemo merged commit 47d23a5 into main Feb 12, 2024
6 checks passed
@tamirhemo tamirhemo deleted the tamir/fix-stark branch February 13, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants