feat: groth16 feature flag #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctian1
approved these changes
May 22, 2024
| ```toml | ||
| sp1-sdk = { features = ["groth16"] } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
would be good to add a note here about installing go >1.22.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
groth16feature flag torecursion-ffi,proverandsdk.In
recursion-ffiandproverit's enabled by default, because SP1 core developers should havegoand need to often test the e2e flow with Groth16.On the other hand, SP1 users who wish to use SP1 with Groth16 proving/verification should enable
groth16feature on the SDK. This ensures users of SP1 who are not usinggroth16proofs do not need Go.