Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: put hook results in front of the input stream #973

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat: put hook results in front of the input stream #973

merged 1 commit into from
Jun 24, 2024

Conversation

tqn
Copy link
Contributor

@tqn tqn commented Jun 24, 2024

Hook results must be accessed immediately after calling.

One no longer has to rely on the input_stream being empty when calling a hook and accessing its results.

@tqn tqn requested a review from ctian1 June 24, 2024 21:30
@tqn tqn changed the title feat: put hook results in front of the stream feat: put hook results in front of the input stream Jun 24, 2024
ctian1
ctian1 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@ctian1 ctian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could use Vec::insert

@tqn tqn merged commit 85671d6 into dev Jun 24, 2024
6 of 7 checks passed
@tqn tqn deleted the tqn/hooks-front-stream branch June 24, 2024 23:24
@huitseeker huitseeker mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctian1 ctian1 ctian1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tqn @ctian1