Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YLDA_HOME environment variable #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

deanmalmgren
Copy link

Hey shravanmn,

I love the YLDA code! I've been using it for a project and I have been impressed by how much better it is than the Mahout LDA implementation both in terms of speed and setup time. Thanks for making this public! I just pushed a couple of minor changes that I needed to do to get things working for my purposes and I thought I would let you know in case you want to pull them into the master branch:

  1. I added a YLDA_HOME environment variable to the runLDA.sh script make it possible to run YLDA from outside of the source root (something that I need to do).
  2. I was having wierd syntax problems on my system with the LDA.sh and runLDA.sh scripts, so I changed these to being /bin/bash based rather than /bin/sh based.

Cheers.
Dean

Dean Malmgren added 3 commits September 6, 2011 10:44
…which was giving me problems. added .gitignore file to repository root.
… is not necessary to run YLDA code from the YLDA root.
@shravanmn
Copy link
Collaborator

Please see in line..

On Tuesday 06 September 2011 09:28 PM, deanmalmgren wrote:

Hey shravanmn,

I love the YLDA code! I've been using it for a project and I have been impressed by how much better it is than the Mahout LDA implementation both in terms of speed and setup time. Thanks for making this public! I just pushed a couple of minor changes that I needed to do to get things working for my purposes and I thought I would let you know in case you want to pull them into the master branch:

Thanks for the good word!

Sure we will be glad to pull in any changes that make things simpler.

  1. I added a YLDA_HOME environment variable to the runLDA.sh script make it possible to run YLDA from outside of the source root (something that I need to do).

Can you expand a bit more on what you mean by outside of the source root?
2. I was having wierd syntax problems on my system with the LDA.sh and runLDA.sh scripts, so I changed these to being /bin/bash based rather than /bin/sh based.

Oh can you tell me what the problems were and what is your system
configuration? We have only tested system dependencies so much. Will be
good to see how they can be fixed.

Thanks,
--Shravan

Cheers.
Dean

@deanmalmgren
Copy link
Author

also in line...but before I get to that I thought I should mention that
if there is a better way to implement these things, please let me know.

Thanks again!
Dean

On 2011/09/07 22:52, shravanmn wrote:

  1. I added a YLDA_HOME environment variable to the runLDA.sh script make it possible to run YLDA from outside of the source root (something that I need to do).

Can you expand a bit more on what you mean by outside of the source root?

For example, if we have the YLDA code installed at /usr/lib/ylda and we
are running a script which programatically invokes YLDA from
/some/other/directory, the problem is that the runLDA.sh script assumes
that you are in /usr/lib/ylda (it sources things, etc.). By adding the
YLDA_HOME environment variable it is easy to call runLDA.sh elsewhere.

  1. I was having wierd syntax problems on my system with the LDA.sh and runLDA.sh scripts, so I changed these to being /bin/bash based rather than /bin/sh based.

Oh can you tell me what the problems were and what is your system
configuration? We have only tested system dependencies so much. Will be
good to see how they can be fixed.

I have tried this on fresh installs of Ubuntu 10.04 and 11.04, both
running on a laptop and on an EC2 cluster. Apparently dash is Ubuntu's
replacement for sh and dash is not too fond of "==" for string comparison.

@shravanmn
Copy link
Collaborator

Thanks Dean. This will be useful. Before I can pull this, I need a contribution license agreement signed. You can find the agreement here https://github.com/shravanmn/Yahoo_LDA/raw/master/Contribution_License_Agreement_Yahoo.pdf

If you have trouble signing this document in pdf let me know we can figure out alternate ways to that.

@deanmalmgren
Copy link
Author

Hi Shravan,

Sorry for the belated reply. I had a crunch-time deadline the past few
weeks and I did not have a chance to adequately review the agreement
before today. Attached is the signed contribution license agreement,
giving myself and Mike Stringer the authority to contribute to the YLDA
source on behalf of Datascope Analytics.

If there is anything else you need from us, please let me know.

Cheers.
Dean

On 2011/09/13 03:56, shravanmn wrote:

Thanks Dean. This will be useful. Before I can pull this, I need a contribution license agreement signed. You can find the agreement here https://github.com/shravanmn/Yahoo_LDA/raw/master/Contribution_License_Agreement_Yahoo.pdf

If you have trouble signing this document in pdf let me know we can figure out alternate ways to that.

dean malmgren
+1.312.884.9214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants