Hotfix line endings

[andmetoo]

🔨The ends of lines don't work correctly in the created layer, textarea element is necessary for correct work.

[sudodoki]

Can you provide jsfiddle/jsbin with example of what exactly didn't work for you? Not sure what's your exact problem is, but release https://github.com/sudodoki/copy-to-clipboard/releases/tag/1.1.1 did work with newlines correctly (although there was an issue with content that needed escaping - see some closed issues for more info).

[andmetoo]

Yea you can check jsfiddle
Just past copied data to any spreadsheets, like google spreadsheets.
test in master branch

[sudodoki]

Will try to get to this on weekend, need to figure out if there are other workarounds and test usual test cases.

[sudodoki]

Thanks for bringing this up.

[andmetoo]

There are no problems, can help at any time with any questions

[shvaikalesh]

@sudodoki if this PR passes the tests, we can merge it, make couple fixes and release new patch (3.0.5). With textarea we will drop couple variables and make code a little better.

[sudodoki]

@shvaikalesh need to verify we are not going to run into issues with multiline text and final newline in chrome/safari vs firefox in textarea as during writing e2e test it turned out there are inconsistencies (might be only with pasting, and not setting value through js). Don't think I will have time to do that now, although this change might be desirable.

[andmetoo]

hello old fix really has a big problem if the copy 40000 rows. I found a solution which is suitable for all scenarios, this method work in all cases for themselves now. I'm sorry for error.

[shvaikalesh]

innerHTML is not cool. Please, see closed issues for details.

[andmetoo]

yea this is sucks, can we use method depending on the situation?

[SEAPUNK]

Is there any progress on this? This problem is biting me in the ass too. I'm willing to help out, if needed.

[SEAPUNK]

Bump; any updates?

[sudodoki]

@andmetoo @SEAPUNK still didn't have enough time to look into this re #26 (comment). Might consider depending on andmetoo/copy-to-clipboard#hotfix-line-endings from package.json for time being

[andmetoo]

@SEAPUNK U can use directly from my fork
npm install --save https://github.com/andmetoo/copy-to-clipboard/tarball/hotfix-line-endings

[SEAPUNK]

I am, but I prefer that I install from releases.