New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't swallow errors in makenode.js #31

Open

gobengo wants to merge 1 commit into sudomesh:master from gobengo:dont-swallow-errors

Contributor

gobengo commented Jul 5, 2018

Today @squeeesh and @eenblam and I were setting up an n600. We got a cryptic-ish error from makenode and had to look into the code to diagnose.

There are two things this PR does to make it easier to triage errors in the future

Fix a couple places in async functions where the error object wasn't getting passed to callback
Don't pass strings to error callbacks. Strings don't have useful stack traces. Error objects do.


          Don't swallow errors in makenode.js

80ec7ed

gobengo requested a review from eenblam

July 5, 2018 18:37

Contributor

bennlich commented Jul 5, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet