Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning when longer than 2 whole notes are played #3065

Closed
ashutoshgautams opened this issue Aug 22, 2022 · 3 comments · Fixed by #3067
Closed

Remove warning when longer than 2 whole notes are played #3065

ashutoshgautams opened this issue Aug 22, 2022 · 3 comments · Fixed by #3067

Comments

@ashutoshgautams
Copy link
Contributor

Remove the WARNING when you try to play a note longer than 2 whole notes since some samples are very long.
@ashutoshgautams ashutoshgautams mentioned this issue Aug 24, 2022
Merged
@ashutoshgautams ashutoshgautams mentioned this issue Aug 29, 2022
Closed
@debarkamondal
Copy link

I went to the hosted website and tried creating note which takes 4 bars in total and no popup came. Is this error fixed or am I missing somehting?

I would like to contribute to this issue since I am a beginner

@walterbender
Copy link
Member

I think this issue is already taken care of... other "good first issue" to choose from.

@debarkamondal
Copy link

Okay I will try another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed warning
3 participants
@walterbender @debarkamondal @ashutoshgautams