Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismissing an error message removeArrow() is not found #3066

Closed
ashutoshgautams opened this issue Aug 22, 2022 · 18 comments
Closed

dismissing an error message removeArrow() is not found #3066

ashutoshgautams opened this issue Aug 22, 2022 · 18 comments
Labels
Good first issue Issue-Bug Priority-Minor Nice to have

Comments

@ashutoshgautams
Copy link
Contributor

Steps to recreate :-

create a note with 4/1 as its note value. when you play it, a warning message appears. click on the x to dismiss the message... the arrow will not be removed.

image
@ashutoshgautams ashutoshgautams mentioned this issue Aug 29, 2022
Merged
@ashutoshgautams
Copy link
Contributor Author

closed in #3067
connected to #3065

@ashutoshgautams
Copy link
Contributor Author

the error with the arrow, it can be triggered by any error message, so, no, it is not yet resolved.

@AnkanSen
Copy link

AnkanSen commented Jan 12, 2023 •
edited
Loading

Can You please Elaborate on the place where it should be done? I want to contribute to this issue.

@ManavSarkar
Copy link
Contributor

I couldn't find the problem, followed your steps

@IayushCoderJOD
Copy link

@Traitor000 plz assign this to me , I had already done this same functionality back on my hackathon project and quite familiar with it how it's done. Thanks

image

@shashank022002
Copy link

I didn't get what you want the program to do. Should the arrows be removed as soon as the 'X' button is hit or something else?

@Keerthivardhan1
Copy link

I have played note value 4/1 but i did not get any kind of warning message.

@nahianhasan161
Copy link

nahianhasan161 commented Feb 4, 2023 •
edited
Loading

hideArrowsProblem
It seems like if you cancel any warning sign it can't find the "hide Arrows" function and couldn't remove arrows.

hideArrowsCodeSolve2
it seems like on "activity.js" "hideArrows" variable is defined but index.html can't access the function type variable. And this pis of code would solve the problem : // window.hideArrows = hideArrows; //

Vivekk-11 added a commit to Vivekk-11/Vivek-musicblocks that referenced this issue Feb 5, 2023
@Vivekk-11
dismissing an error message removeArrow() is not found (sugarlabs#3066)
632946a
@Vivekk-11
Copy link

Hey @Traitor000, I've made a Pull Request. Could you see it, please?

@nahianhasan161 nahianhasan161 mentioned this issue Feb 6, 2023
Closed
Vivekk-11 added a commit to Vivekk-11/Vivek-musicblocks that referenced this issue Feb 7, 2023
@Vivekk-11
dismissing an error message removeArrow() is not found (sugarlabs#3066)
e6857c6
@Jastagar
Copy link

Jastagar commented Feb 7, 2023

Hi, Can I please help you in fixing it? I have good knowledge of JS and web-dev.

@ashutosh887
Copy link

@Traitor000 Should I work on it if it's still not resolved?
Please assign this issue to me!

@priyangshusarkar77
Copy link

so can i help you in this i have a good amount of knowledge

@Chiragmanral
Copy link

i wanna help you in solving this issue.

@priyangshusarkar77
Copy link

priyangshusarkar77 commented Feb 27, 2023 via email

shahkushal38 added a commit to shahkushal38/musicblocks that referenced this issue Mar 24, 2023
@shahkushal38
fixes issue sugarlabs#3066 - dismissing an error message removeArrow(…
1526ea1 
…) is not found
@shahkushal38 shahkushal38 mentioned this issue Mar 24, 2023
Merged
@shahkushal38
Copy link
Contributor

@Traitor000 and @walterbender could you review this pull request, it solves the issue to the best of my knowledge

the error message
2

After dissiming the error message
3

shahkushal38 added a commit to shahkushal38/musicblocks that referenced this issue Mar 25, 2023
@shahkushal38
fixes issue sugarlabs#3066
ab08c03
walterbender pushed a commit that referenced this issue Mar 25, 2023
@shahkushal38
fixes issue #3066 - to remove arrows on dismissing error message (#3222)
ed7e117 
* fixes issue #3066 - dismissing an error message removeArrow() is not found

* fixes issue #3066
Ashnidh pushed a commit to Ashnidh/musicblocks that referenced this issue Mar 25, 2023
@shahkushal38 @Ashnidh
fixes issue sugarlabs#3066 - to remove arrows on dismissing error mes…
0ecd48c 
…sage (sugarlabs#3222)

* fixes issue sugarlabs#3066 - dismissing an error message removeArrow() is not found

* fixes issue sugarlabs#3066
@Aryan-Mishra24
Copy link

i'd love to work on this issue or help and collaborate with whoever is working on it

@walterbender
Copy link
Member

I think this issue is fixed.

MohitGupta14 pushed a commit to MohitGupta14/sugarLabs-musicblocks that referenced this issue Apr 13, 2023
@shahkushal38 @MohitGupta14
fixes issue sugarlabs#3066 - to remove arrows on dismissing error mes…
81c0770 
…sage (sugarlabs#3222)

* fixes issue sugarlabs#3066 - dismissing an error message removeArrow() is not found

* fixes issue sugarlabs#3066
MohitGupta14 pushed a commit to MohitGupta14/sugarLabs-musicblocks that referenced this issue Jun 16, 2023
@shahkushal38 @MohitGupta14
fixes issue sugarlabs#3066 - to remove arrows on dismissing error mes…
d373a9f 
…sage (sugarlabs#3222)

* fixes issue sugarlabs#3066 - dismissing an error message removeArrow() is not found

* fixes issue sugarlabs#3066
walterbender added a commit that referenced this issue Jun 29, 2023
@MohitGupta14 @shahkushal38
@TheCharismaticEnigma @walterbender
Recording Feature implementation (#3272)
f260e1d 
* Take a tour section became responsive for all kind of smartphones

* making responsive and adjusting the size of the icons according to different screen sizes

* fixing Interval number and Movabledo  in take a tour section

* updating activities file

* Implementation of Recording button Feature

* updating activities file

* fixes issue #3066 - to remove arrows on dismissing error message (#3222)

* fixes issue #3066 - dismissing an error message removeArrow() is not found

* fixes issue #3066

* Fix the redundant display of error messages despite availability of cards (#3231)

* Implementation of Recording button Feature

* Enhancement: Upgrade the files from Constructor function to ES6 class syntax  (#3265)

* Upgrade Planet.js file

* Upgrade GlobalPlanet.js File

* FUll-SCREEN MODE (#3253)

* Enhancement: Upgrade constructor function to ES6 class syntax.  (#3268)

* Upgrade ProjectViewer.js file

* Upgrade GlobalCard.js file

* Upgrade GlobalTag.js File

* Upgrade LocalPlanet.js File

* Upgrade Publisher.js File

* Upgrade LocalCard.js File

* Full screen help (#3269)

* Upgrade ProjectViewer.js file

* Upgrade GlobalCard.js file

* Upgrade GlobalTag.js File

* Upgrade LocalPlanet.js File

* Upgrade Publisher.js File

* Upgrade LocalCard.js File

* add help for full screen

---------

Co-authored-by: TheCharismaticEnigma <avishkar2002@mail.com>

* Implementation of Recording button Feature

* Now current tab can be recorded in Chrome and opera

* Record And FullScreen Functionality

* Recording button version 3

* Adding materialise and blinking effect in rec-btn

* Making recording button unclickable when its in use

* changes in index

* implemeting SVGs to record button

* exporting recording script code to js files and implementing SVGs

* changing dimensions in record svg and deleting ide files:

* deleting idea file

* Making Record button unclickable while recording:

* Currently user needed to click two times while starting the first recording , this problem arises after exporting the code

* indentation

* Making Record a advance feature and changing styling and blinking effect on clicking the Rec button

* Removing Record feature from firefox and exporting browser detection code from acticity.js to utils.js

* linting

* linting

* linting

---------

Co-authored-by: Kushal Shah <60709835+shahkushal38@users.noreply.github.com>
Co-authored-by: TheCharismaticEnigma <102666605+TheCharismaticEnigma@users.noreply.github.com>
Co-authored-by: Walter Bender <walter@sugarlabs.org>
Co-authored-by: TheCharismaticEnigma <avishkar2002@mail.com>
Co-authored-by: Walter Bender <walter@sorcero.com>
@zahidhussain998
Copy link

hey there, i would like to work this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Issue-Bug Priority-Minor Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests