Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed js/widgets/ fixed #2198 #3133

Closed
wants to merge 1 commit into from

Conversation

RiteshSinha919
Copy link
Contributor

@RiteshSinha919 RiteshSinha919 commented Jan 29, 2023

  • js/widgets/

Info:
While changing the function to Arrow Function, the variable 'widgetWindow' was having an error for these files
musickeyboard.js line 445
sampler.js line 198
temperament.js line 2023

Error message:
Cannot redeclare block-scoped variable 'widgetWindow'

I haven't changed the function to arrow function for these 3 lines

@walterbender
Copy link
Member

Probably we want to refactor those widgets that are not defined as classes to the class format. That should be done first.

@RiteshSinha919 RiteshSinha919 changed the title changed js/widgets/ changed js/widgets/ as mentioned in sugarlabs#2198 Jan 30, 2023
@RiteshSinha919 RiteshSinha919 changed the title changed js/widgets/ as mentioned in sugarlabs#2198 changed js/widgets/ fixed #2198 Jan 30, 2023
@RiteshSinha919
Copy link
Contributor Author

@walterbender okay, so do I need to close the pull request or keep it open

@walterbender
Copy link
Member

I think we should remove the commits to the three widgets that need to be refactors. I'll merge it and then we can make a separate PR for the refactored code. Sound OK?

@RiteshSinha919
Copy link
Contributor Author

@walterbender sounds good, which 3 widget files need to be refactored?

@walterbender
Copy link
Member

I think it is the 3 you had trouble with: temperament, sampler, and musickeyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants