Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: libs #166

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

feat: libs #166

wants to merge 17 commits into from

Conversation

sugyan
Copy link
Owner

@sugyan sugyan commented May 2, 2024

  • common-web
  • crypto
  • identity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types already exist in atrium_api::did_doc (and look almost identical, other than missing the context field on DidDocument). Is the plan to move these types out of atrium-api, or is this just a temporary duplication as part of figuring out where atrium-libs sits in the crate dependency tree?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look!
Yes, currently I am thinking of removing atrium_api::did_doc and referencing common_web::did_doc from the api by adding these new libs.

@sugyan sugyan mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants