-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: libs #166
base: main
Are you sure you want to change the base?
feat: libs #166
Conversation
sugyan
commented
May 2, 2024
- common-web
- crypto
- identity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types already exist in atrium_api::did_doc
(and look almost identical, other than missing the context
field on DidDocument
). Is the plan to move these types out of atrium-api
, or is this just a temporary duplication as part of figuring out where atrium-libs
sits in the crate dependency tree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look!
Yes, currently I am thinking of removing atrium_api::did_doc
and referencing common_web::did_doc
from the api by adding these new libs.