custom transfer handler #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VLegakis
reviewed
Dec 9, 2024
sips/sip-temporary_title.md
Outdated
|
|
||
| ## Abstract | ||
|
|
||
| Introduce a standardized custom transfer handler interface in the Sui wallet to support assets with complex transfer logic, such as NFTs that require additional state updates or validation during transfers. |
There was a problem hiding this comment.
Just a minor comment: maybe good to add the term business logic in place e.g of complex logic
|
Yeah sure. I am updating it and creating new pull request.
…On Mon, 9 Dec 2024 at 7:48 PM, Vassilis Legakis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sips/sip-temporary_title.md
<#46 (comment)>:
> +| SIP-Number | TBD |
+| ---: | :--- |
+| Title | Custom Transfer Handler Support for Sui Wallet |
+| Description | Standardize custom transfer behavior for complex assets |
+| Author | Tushar Sengar |
+| Editor | TBD |
+| Type | Standard |
+| Category | Wallet |
+| Created | 2024-12-09 |
+| Comments-URI | https://sips.sui.io/comments-TBD |
+| Status | Draft |
+| Requires | |
+
+## Abstract
+
+Introduce a standardized custom transfer handler interface in the Sui wallet to support assets with complex transfer logic, such as NFTs that require additional state updates or validation during transfers.
Just a minor comment: maybe good to add the term business logic in place
e.g of complex logic
—
Reply to this email directly, view it on GitHub
<#46 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6IQVJI6Y3ZF7NORCGTQDWL2EWRDNAVCNFSM6AAAAABTIJ7MQCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBYHEYTOMRRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi, I have changed the text to business logic and pushed the update. Thanks
…On Mon, 9 Dec 2024 at 20:00, torque network ***@***.***> wrote:
Yeah sure. I am updating it and creating new pull request.
On Mon, 9 Dec 2024 at 7:48 PM, Vassilis Legakis ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In sips/sip-temporary_title.md
> <#46 (comment)>:
>
> > +| SIP-Number | TBD |
> +| ---: | :--- |
> +| Title | Custom Transfer Handler Support for Sui Wallet |
> +| Description | Standardize custom transfer behavior for complex assets |
> +| Author | Tushar Sengar |
> +| Editor | TBD |
> +| Type | Standard |
> +| Category | Wallet |
> +| Created | 2024-12-09 |
> +| Comments-URI | https://sips.sui.io/comments-TBD |
> +| Status | Draft |
> +| Requires | |
> +
> +## Abstract
> +
> +Introduce a standardized custom transfer handler interface in the Sui wallet to support assets with complex transfer logic, such as NFTs that require additional state updates or validation during transfers.
>
> Just a minor comment: maybe good to add the term business logic in place
> e.g of complex logic
>
> —
> Reply to this email directly, view it on GitHub
> <#46 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6IQVJI6Y3ZF7NORCGTQDWL2EWRDNAVCNFSM6AAAAABTIJ7MQCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBYHEYTOMRRGQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a standardized custom transfer handler interface in the Sui wallet to support assets with complex transfer logic, such as NFTs that require additional state updates or validation during transfers.