Tweak initial high signal of protocol 3 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves issue sui77#32 (with a recent Globaltronics GT-FSI-07), and also is necessary for compatibility with my Brennenstuhl RCS 2044.
|
@sui77 I am hoping that you remember something about this? |
|
Went trough logs and mails... protocol 3 was added in 2013 for Brennenstuhl RC 3600. I also think that most likely the tweak is correct and RC3600 are fault-tolerant. |
sui77
added a commit
that referenced
this pull request
Mar 1, 2016
Tweak initial high signal of protocol 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #32 (with a recent Globaltronics GT-FSI-07), and also is necessary
for compatibility with my Brennenstuhl RCS 2044.
However, it might break existing users of protocol 3 (which is why I did not commit this directly).
Unfortunately, I have no idea of which devices that might be. The commit 9f1bf10 which added protocol 3 gives no hints (as far as I could tell) what devices need it. And the Wiki does not mention any device using protocol 3 either.
And of course our receiving code ignores the initial high (which one might consider a bug...) and thus receiving works well with our without this patch. So perhaps the device(s) for which protocol 3 was originally added are fine with this patch, too?