Skip to content

🐛 Fix some windows compatibilities #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

🐛 Fix some windows compatibilities #1263

merged 2 commits into from
Aug 7, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Aug 4, 2025

Purpose

The project has some compatibilities issues with Windows.

Proposal

  • 🐛(makefile) Windows compatibility fix for Docker volume mounting
  • 🐛(minio) fix user permission error with Minio and Windows

@AntoLC AntoLC self-assigned this Aug 4, 2025
@AntoLC AntoLC added bug Something isn't working docker labels Aug 4, 2025
@AntoLC AntoLC force-pushed the fix/windows-compatibility branch from 2c6fe4b to 5776ea4 Compare August 4, 2025 14:17
@AntoLC AntoLC requested review from Ovgodd and lunika August 5, 2025 09:22
Ovgodd
Ovgodd reviewed Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@Ovgodd Ovgodd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected behavior (immediate duplication) is not consistent.

Hey ! after few tests on my side :

Only sub-documents can be duplicated without any constraints (like title or content).

For other types of documents, especially main, public, or empty ones, duplication likely requires some mandatory fields, such as a title. ( error 500 instead )

@AntoLC
Copy link
Collaborator Author

AntoLC commented Aug 6, 2025 •
edited by Ovgodd
Loading

The expected behavior (immediate duplication) is not consistent.

Hey ! after few tests on my side :

Only sub-documents can be duplicated without any constraints (like title or content).

For other types of documents, especially main, public, or empty ones, duplication likely requires some mandatory fields, such as a title. ( error 500 instead )

I don't think it is related to this PR, this PR fixes the make bootstrap on Windows with mails-install part, and the MinIO permission problem on Windows as well.

But good spot, could you open an issue about it ?

@Ovgodd
Copy link
Collaborator

Ovgodd commented Aug 7, 2025

The expected behavior (immediate duplication) is not consistent.
Hey ! after few tests on my side :
Only sub-documents can be duplicated without any constraints (like title or content).
For other types of documents, especially main, public, or empty ones, duplication likely requires some mandatory fields, such as a title. ( error 500 instead )

I don't think it is related to this PR, this PR fixes the make bootstrap on Windows with mails-install part, and the MinIO permission problem on Windows as well.

But good spot, could you open an issue about it ?

Oh sorry yes this is not related to this PR, for this one :
I tried make bootstrap FLUSH_ARGS='--no-input' no more crash with the email thing but I have this :
`make[1]: Leaving directory 'C:/Users/Desktop/dinum/docs'
[+] Running 0/1
[+] Running 0/1cs-frontend-development-1 Rec
[+] Running 0/1cs-frontend-development-1 Rec
[+] Running 0/1cs-frontend-development-1 Sta

  • Container docs-frontend-development-1 Starting0.3s
    Error response from daemon: Ports are not available: exposing port TCP 0.0.0.0:3000 -> 127.0.0.1:0: listen tcp 0.0.0.0:3000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
    make: *** [Makefile:160: run] Error 1`

I tried again after running make bootstrap FLUSH_ARGS='--no-input', and I was not able to reproduce the duplication issue anymore 😮

@Ovgodd Ovgodd self-requested a review August 7, 2025 10:29
Ovgodd
Ovgodd approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

AntoLC added 2 commits August 7, 2025 12:36
@AntoLC
🐛(makefile) Windows compatibility fix for Docker volume mounting
7be761c 
On Windows systems, Docker volume paths starting
with a single / can be interpreted incorrectly
by the Docker daemon. The double slash (//) helps
Docker on Windows properly interpret the path as
an absolute path within the container, ensuring
that the working directory is correctly set
when running mail-related yarn commands.
@AntoLC
🐛(minio) fix user permission error with Minio and Windows
0cf8b9d 
With Minio Docker and Windows, the user ID needs
 to be set to `0:0` to avoid permission issues.
 This change ensures that the Minio container
 runs with root privileges on Windows, which
 is necessary for proper file access and management.
@AntoLC AntoLC force-pushed the fix/windows-compatibility branch from 5776ea4 to 0cf8b9d Compare August 7, 2025 10:37
@AntoLC AntoLC merged commit 0cf8b9d into main Aug 7, 2025
20 of 21 checks passed
@AntoLC AntoLC deleted the fix/windows-compatibility branch August 7, 2025 10:53
@AntoLC AntoLC mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ovgodd Ovgodd Ovgodd approved these changes

@lunika lunika Awaiting requested review from lunika

Assignees

@AntoLC AntoLC

Labels

bug Something isn't working docker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AntoLC @Ovgodd