Skip to content

Conversation

joehybird
Copy link
Contributor

@joehybird joehybird commented Aug 13, 2025

Purpose

On some environments keycloak returns a 'HTTPS required' message on login.
The same issue was fixed in drive by changing the 'sslRequired' value from 'external' to 'none' in all realms configuration (see suitenumerique/drive#291).

Also upgrade keycloak up to 26.3.2

@joehybird joehybird force-pushed the fix/keycloak-dev-https-required branch 3 times, most recently from f1da4c9 to e2c8aff Compare August 13, 2025 09:16
compose.yml Outdated
- --proxy=edge
- --hostname-url=http://localhost:8083
- --hostname-admin-url=http://localhost:8083/
# - --proxy=edge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - --proxy=edge

If it's not used, can it be removed?

compose.yml Outdated
- --metrics-enabled=true
healthcheck:
test: ["CMD", "curl", "--head", "-fsS", "http://localhost:8080/health/ready"]
test: ['CMD-SHELL', '[ -f /tmp/HealthCheck.java ] || echo "public class HealthCheck { public static void main(String[] args) throws java.lang.Throwable { java.net.URI uri = java.net.URI.create(args[0]); System.exit(java.net.HttpURLConnection.HTTP_OK == ((java.net.HttpURLConnection)uri.toURL().openConnection()).getResponseCode() ? 0 : 1); } }" > /tmp/HealthCheck.java && java /tmp/HealthCheck.java http://localhost:9000/health/live']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's not easier to remove the healthcheck instead of having to maintain this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it seems easier to maintain ? can be moved in a script.
['CMD-SHELL', 'exec 3<>/dev/tcp/localhost/9000; echo -e "GET /health/ready/live HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n" >&3; grep "HTTP/1.1 200 OK" <&3']

@joehybird joehybird force-pushed the fix/keycloak-dev-https-required branch 2 times, most recently from d2f9f01 to c7b2995 Compare September 2, 2025 09:46
@joehybird joehybird force-pushed the fix/keycloak-dev-https-required branch 6 times, most recently from 5868180 to 858b506 Compare September 10, 2025 05:55
@joehybird joehybird requested a review from AntoLC September 10, 2025 07:52
@joehybird joehybird force-pushed the fix/keycloak-dev-https-required branch 3 times, most recently from 2085625 to b6f3ba6 Compare September 15, 2025 07:58
On some environments keycloak returns a 'HTTPS required' message on login.
The same issue was fixed in drive by changing the 'sslRequired' value
from 'external' to 'none'.
Also upgrade keycloak up to 26.3.2

Signed-off-by: Fabre Florian <ffabre@hybird.org>
Fix the keyCloakSignIn() function for the new login page.

Signed-off-by: Fabre Florian <ffabre@hybird.org>
@joehybird joehybird force-pushed the fix/keycloak-dev-https-required branch from b6f3ba6 to 0dd6818 Compare September 15, 2025 09:19
@joehybird joehybird merged commit 0dd6818 into main Sep 15, 2025
28 of 30 checks passed
@joehybird joehybird deleted the fix/keycloak-dev-https-required branch September 15, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants