Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Sep 8, 2025

Purpose

Improve the accessibility of the modal by structuring content properly, adding a descriptive title, and clarifying button labels.

issue : 899

Proposal

  • Structure modal text inside a p element
  • Add a h1 title with id and reference it via aria-describedby
  • Replace ambiguous aria-labels for "cancel" and "delete" buttons
  • Replace ambiguous aria-labels for "cancel" and "delete" buttons
  • Add a sr-only class to visually hide the modal title while keeping it accessible to screen readers

The sr-only class hides content from visual display but keeps it readable by screen readers. This ensures assistive technologies can announce the modal's purpose without affecting the UI layout.

@Ovgodd Ovgodd requested a review from AntoLC September 8, 2025 10:02
@Ovgodd Ovgodd self-assigned this Sep 8, 2025
@Ovgodd Ovgodd force-pushed the fix/899-modal-a11y branch 3 times, most recently from 62d3cae to 3b10b6e Compare September 8, 2025 11:33
Copy link

github-actions bot commented Sep 8, 2025

Size Change: +324 B (+0.01%)

Total Size: 3.65 MB

Filename Size Change
apps/impress/out/_next/static/4ef99bd8/_buildManifest.js 0 B -867 B (removed) 🏆
apps/impress/out/_next/static/css/097de668257d29b5.css 0 B -25.1 kB (removed) 🏆
apps/impress/out/_next/static/905ef816/_buildManifest.js 867 B +867 B (new file) 🆕
apps/impress/out/_next/static/css/e6db258771d1472b.css 25.2 kB +25.2 kB (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/899-modal-a11y branch 2 times, most recently from f2222ad to 440be24 Compare September 9, 2025 08:17
@Ovgodd Ovgodd force-pushed the fix/899-modal-a11y branch from edce077 to 26e7886 Compare September 9, 2025 11:00
@Ovgodd Ovgodd requested a review from AntoLC September 9, 2025 11:44
@Ovgodd Ovgodd marked this pull request as ready for review September 9, 2025 11:44
@Ovgodd Ovgodd force-pushed the fix/899-modal-a11y branch from 26e7886 to 1601e78 Compare September 9, 2025 11:45
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 !

@Ovgodd Ovgodd force-pushed the fix/899-modal-a11y branch 2 times, most recently from 8ff6d30 to 9a7b6ac Compare September 9, 2025 16:32
added aria-label, structured text in p, and added title for better accessibility

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd merged commit 8a310d0 into main Sep 10, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/899-modal-a11y branch September 10, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants