⚗️(service-worker) remove index from cache first strategy #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -24 B (0%) Total Size: 3.65 MB
|
AntoLC
force-pushed
the
refacto/sw-change-strategy
branch
from
3f21299 to
7963d49
Compare
lunika
approved these changes
Sep 18, 2025
Some users reported that the app was giving a blank page, it seems to happens often after a release. It could be due to the fact that the service worker is caching the index.html file and not updating it properly after a new release. We remove the index from the cache first strategy to avoid this kind of issue. We set as well the default handler with the "StaleWhileRevalidate" strategy to force the cache to be updated in the background.
AntoLC
force-pushed
the
refacto/sw-change-strategy
branch
from
7963d49 to
2dc1e07
Compare
Some tests were getting very flaky due to previous tests updates. This should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some users reported that the app was giving a blank page, it seems to happens often after a release.
It could be due to the fact that the service worker is caching the index.html file and not updating it properly after a new release.
⚗️ We didn't succeeded to reproduce this bug though.
Proposal
We remove the index from the cache first strategy to avoid this kind of issue. We set as well the default handler with the "StaleWhileRevalidate" strategy to force the cache to be updated in the background.