-
Couldn't load subscription status.
- Fork 416
✨(frontend) improve NVDA navigation in DocShareModal #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3970af0 to
9880d1d
Compare
|
Size Change: +49 B (0%) Total Size: 3.65 MB
|
3256b4f to
28f34ce
Compare
src/frontend/apps/e2e/__tests__/app-impress/doc-member-create.spec.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/components/quick-search/QuickSearchInput.tsx
Outdated
Show resolved
Hide resolved
8edf1e2 to
03d3bc0
Compare
03d3bc0 to
72b3b4b
Compare
72b3b4b to
da4ed5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we have to update this test, the development does not seem to touch really this part.
I can see it is still mocking the users request, it should not, it is not asserting anymore that the users are correctly displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree, that was a mistake !
51a37fd to
dde32e0
Compare
6861750 to
d86027b
Compare
ebe8134 to
f420622
Compare
fix NVDA focus and announcement issues in search modal combobox Signed-off-by: Cyril <c.gromoff@gmail.com>
f420622 to
ee3b05c
Compare
Purpose
Fix UX and accessibility violations in DocShareModal where QuickSearch auto-selected the first result on open, causing NVDA to immediately announce "John Doe impress@impress.world" despite focus being in the search input.
This violated UX principles (user consent, predictability) and WCAG
Proposal