♻️(frontend) replace Arial font-family with token font #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/replace-arial
branch
from
f116ef5 to
7c001ab
Compare
Closed
|
Size Change: -22 B (0%) Total Size: 3.65 MB
|
Some improvements has been made to the Marianne fonts. We replace the previous one with the newer version.
In some components, the Arial font was still used because of a centering problem. We removed all instances of Arial and replaced them with the current font token, the centering problems were fixed by adding "contain: content;" to the css.
AntoLC
force-pushed
the
refacto/replace-arial
branch
from
7c001ab to
a751f12
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In some components, the Arial font was still used because of a centering problem.
Proposal
We removed all instances of Arial and replaced them with the current font token, the centering problems
were fixed by adding "contain: content;" to the css.
Demo
Before:
After: