✨(frontend) remove redundant aria-label to avoid over-accessibility #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/1401-avoid-over-a11y
branch
from
8c74049 to
07455ce
Compare
|
Size Change: +6 B (0%) Total Size: 3.65 MB
|
Ovgodd
force-pushed
the
fix/1401-avoid-over-a11y
branch
from
07455ce to
72a6f9b
Compare
AntoLC
approved these changes
Sep 22, 2025
Ovgodd
force-pushed
the
fix/1401-avoid-over-a11y
branch
4 times, most recently
from
cbf28d1 to
0505619
Compare
aria-label was removed because the visible span already provides the text Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/1401-avoid-over-a11y
branch
from
0505619 to
3607faa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove a redundant aria-label avoiding over-accessibility and prevent screen readers from duplicating content already present in a visible span
issue : 1401
Proposal