♿(frontend) improve semantic structure and aria roles of leftpanel #1431
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/1429-left-panel-semantic
branch
from
a15d892 to
ee12135
Compare
|
Size Change: +16 B (0%) Total Size: 3.65 MB
|
Ovgodd
force-pushed
the
fix/1429-left-panel-semantic
branch
from
ee12135 to
f382533
Compare
use nav and appropriate aria attributes to enhance accessibility Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/1429-left-panel-semantic
branch
from
f382533 to
8ab21ef
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR improves the semantic structure and accessibility of the left panel ( TargetFilters and Favorites too) .
issue : 1429
Proposal
navwith appropriate aria-labelsnavwithsectionfor grouped pinned content