Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Sep 24, 2025

Purpose

Improve accessibility by removing redundant aria-label attributes on icons that are already hidden (aria-hidden="true").
Tests have been updated to rely on stable data-testid attributes instead of accessibility labels

issue : 1427

arialabeldocicon

Proposal

  • Remove unnecessary aria-label from icons with aria-hidden="true
  • Ensure semantic accessibility remains intact
  • Update test suite to use data-testid attributes for selectors

@Ovgodd Ovgodd requested a review from AntoLC September 24, 2025 08:26
@Ovgodd Ovgodd self-assigned this Sep 24, 2025
@Ovgodd Ovgodd force-pushed the fix/1427-remove-label-from-hidden-aria branch from a6930d5 to 22bbed0 Compare September 24, 2025 08:27
@Ovgodd Ovgodd marked this pull request as ready for review September 24, 2025 08:27
Copy link

github-actions bot commented Sep 24, 2025

Size Change: -31 B (0%)

Total Size: 3.65 MB

Filename Size Change
apps/impress/out/_next/static/b8e02a25/_buildManifest.js 0 B -865 B (removed) 🏆
apps/impress/out/_next/static/cda80774/_buildManifest.js 866 B +866 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/1427-remove-label-from-hidden-aria branch 4 times, most recently from c5a6559 to 80190e5 Compare September 24, 2025 10:18
remove aria-label from aria-hidden icons and update tests with data-testid

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/1427-remove-label-from-hidden-aria branch from 80190e5 to 1fdf70b Compare September 24, 2025 11:19
@Ovgodd Ovgodd merged commit 1fdf70b into main Sep 24, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1427-remove-label-from-hidden-aria branch September 24, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants