Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 2, 2025

Purpose

Ensure proper permissions handling in callouts by preventing users with reader role from editing the emoji.

Enregistrement.de.l.ecran.2025-10-02.145335.mp4

issue : 1410

Proposal

  • Restrict callout emoji editing to users with sufficient permissions
  • Readers can still view callouts but cannot modify the emoji
  • Editors and above keep full editing rights
  • Remove UX feedback in reader mode to avoid users thinking they can take action.

@Ovgodd Ovgodd requested a review from AntoLC October 2, 2025 13:02
@Ovgodd Ovgodd self-assigned this Oct 2, 2025
@Ovgodd Ovgodd added bug Something isn't working frontend triage labels Oct 2, 2025
@Ovgodd Ovgodd force-pushed the fix/1410-change-emoji-reader-right branch from 93ae142 to 9fd303c Compare October 2, 2025 13:02
@Ovgodd Ovgodd marked this pull request as ready for review October 2, 2025 13:05
Copy link

github-actions bot commented Oct 2, 2025

Size Change: +54 B (0%)

Total Size: 3.65 MB

Filename Size Change
apps/impress/out/_next/static/81eb1224/_buildManifest.js 0 B -864 B (removed) 🏆
apps/impress/out/_next/static/0f26353d/_buildManifest.js 864 B +864 B (new file) 🆕

compressed-size-action

@AntoLC AntoLC linked an issue Oct 3, 2025 that may be closed by this pull request
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! 🎉

restrict callout emoji editing to maintain proper permissions

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/1410-change-emoji-reader-right branch from 9fd303c to 5184723 Compare October 6, 2025 08:45
@Ovgodd Ovgodd merged commit 5184723 into main Oct 6, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1410-change-emoji-reader-right branch October 6, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛Can change emoji when reader role

2 participants