✨ List and restore deleted docs #1450
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +968 B (+0.03%) Total Size: 3.66 MB
|
AntoLC
force-pushed
the
feature/bin-in-docs
branch
3 times, most recently
from
6155329 to
9bb3f51
Compare
To know when a document in the trashbin will be permanently deleted.
The front needs to know when a document has been deleted. We expose the deleted_at property on a document object,
The abilities for a deleted document were too open. We want to restrict them. Only the restore, retrieve and tree is allowed. The tree method will need some modifications to get the right informations.
The tree endpoint will now return a result only for owners. For other users the endpoint still returns a 403. Also, the endpoint does look for ancestors anymore, it only stay on the current document.
List the docs deleted in the trashbin list, it is displayed in the docs grid.
We can now restore a doc from the trashbin list actions.
Whe the doc is deleted, the doc page is a bit different, we have to adapt the doc header to add some information and actions that are relevant for a deleted doc.
AntoLC
force-pushed
the
feature/bin-in-docs
branch
from
7616ea8 to
a9be1c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to be able to see the deleted documents, and to restore them if needed.
Proposal
Demo
🚨 Take care
After
TRASHBIN_CUTOFF_DAYSdays, the doc will be definitively deleted, 30 by default.docs/src/backend/impress/settings.py
Lines 430 to 432 in 9bb3f51