-
Notifications
You must be signed in to change notification settings - Fork 409
🍱(frontend) Fonts GDPR compliants #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +599 B (+0.02%) Total Size: 3.66 MB
|
fef136a
to
c2cacb0
Compare
This was
linked to
issues
Oct 6, 2025
We now use Marianne font from @gouvfr-lasuite/ui-kit package instead of a versionned local copies. This ensures we always use the latest version of the font. During a build or dev command, Marianne font files are copied from node_modules to the public assets folder. They can stop being versionned.
c2cacb0
to
c75d9e4
Compare
Ovgodd
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good improvement for GDPR, nice
We now use exported emoji from emoji-datasource-apple package instead of relying on a CDN. During a build or dev command, the emoji images are copied from node_modules to the public assets folder. They are not versionned.
We now use @fontsource-variable/inter package instead of relying on a Google CDN.
Google fonts are not GDPR. We remove them and use system fonts instead.
c75d9e4
to
e3b2fdb
Compare
This part (♻️(frontend) Marianne single source of truth) can be improved when this will be merged: suitenumerique/ui-kit#121 |
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some fonts were not GPDR compliant because of the use of the Google or Cloudflare cdn.
The emoji based on Cloudflare CDN were creating a bug as well, due to missing emoji without fallback.
Proposal
We now embark the fonts and emoji (Inter / Emoji).