Skip to content

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Oct 3, 2025

Purpose

Some fonts were not GPDR compliant because of the use of the Google or Cloudflare cdn.
The emoji based on Cloudflare CDN were creating a bug as well, due to missing emoji without fallback.

Proposal

We now embark the fonts and emoji (Inter / Emoji).


  • ♻️(frontend) Marianne single source of truth
  • 🍱(frontend) manage export emoji locally
  • 🍱(frontend) manage Inter font locally
  • 🔥(mail) replace google font Roboto

@AntoLC AntoLC self-assigned this Oct 3, 2025
@AntoLC AntoLC added bug Something isn't working frontend export labels Oct 3, 2025
@AntoLC AntoLC marked this pull request as draft October 3, 2025 15:53
Copy link

github-actions bot commented Oct 3, 2025

Size Change: +599 B (+0.02%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/1fc99c99/_buildManifest.js 0 B -864 B (removed) 🏆
apps/impress/out/_next/static/css/3152bba33325959c.css 0 B -25.2 kB (removed) 🏆
apps/impress/out/_next/static/241ae69b/_buildManifest.js 881 B +881 B (new file) 🆕
apps/impress/out/_next/static/css/2ee6d170e518968d.css 25.4 kB +25.4 kB (new file) 🆕

compressed-size-action

@AntoLC AntoLC force-pushed the fix/emoji-export-font branch from fef136a to c2cacb0 Compare October 6, 2025 16:44
@AntoLC AntoLC changed the title emoji embarked 🍱Fonts GDPR compliants Oct 6, 2025
@AntoLC AntoLC changed the title 🍱Fonts GDPR compliants 🍱(frontend) Fonts GDPR compliants Oct 6, 2025
We now use Marianne font from @gouvfr-lasuite/ui-kit
package instead of a versionned local copies.
This ensures we always use the latest version of
the font.
During a build or dev command, Marianne font files
are copied from node_modules to the public assets
folder. They can stop being versionned.
@AntoLC AntoLC force-pushed the fix/emoji-export-font branch from c2cacb0 to c75d9e4 Compare October 6, 2025 16:55
@AntoLC AntoLC marked this pull request as ready for review October 6, 2025 16:55
@AntoLC AntoLC requested a review from Ovgodd October 6, 2025 19:39
Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement for GDPR, nice

AntoLC added 3 commits October 7, 2025 09:06
We now use exported emoji from emoji-datasource-apple
package instead of relying on a CDN.
During a build or dev command, the emoji images
are copied from node_modules to the public assets
folder. They are not versionned.
We now use @fontsource-variable/inter package
instead of relying on a Google CDN.
Google fonts are not GDPR. We remove them and use
system fonts instead.
@AntoLC AntoLC force-pushed the fix/emoji-export-font branch from c75d9e4 to e3b2fdb Compare October 7, 2025 07:06
@AntoLC AntoLC merged commit e3b2fdb into main Oct 7, 2025
21 of 22 checks passed
@AntoLC AntoLC deleted the fix/emoji-export-font branch October 7, 2025 07:34
@AntoLC
Copy link
Collaborator Author

AntoLC commented Oct 7, 2025

This part (♻️(frontend) Marianne single source of truth) can be improved when this will be merged: suitenumerique/ui-kit#121

@rvveber
Copy link
Collaborator

rvveber commented Oct 7, 2025

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working export frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on external assets PDF export fetches assets from cloudflare 🐛Some emoji make the export failing
3 participants