🐛(frontend) fix doc timestamp display #1547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the logic to show 'Just now' instead of '0 seconds ago' when the difference is under one second. Signed-off-by: buildwithricky <nwakezepatrick@gmail.com>
Author
Author
|
@rvveber where you able to review this yet the workflow hasn't started |
rvveber
requested changes
Nov 24, 2025
Comment on lines
+25
to
+37
| const dateTime = DateTime.fromISO(date).setLocale(i18n.language); | ||
| const relative = dateTime.toRelative(); | ||
| if (relative) { | ||
| const diffInSeconds = Math.abs(dateTime.diffNow('seconds').seconds); | ||
| if (diffInSeconds < 1) { | ||
| return t('just now'); | ||
| } | ||
| if (relative.includes('0 seconds') || relative.includes('0 second') || | ||
| relative.match(/0\s*(second|seconde|segundo|秒)/i)) { | ||
| return t('just now'); | ||
| } | ||
| } | ||
| return relative; |
Collaborator
There was a problem hiding this comment.
Thanks for your contribution!
- Regex is unnecessary, we have input data so we should use it to calculate the difference
- Locale is only required for displaying and so it would be more readable to set it when displaying
- Always best to name variables explicitly and concisely
- Lets use a timeframe of 5 seconds to display just now for everything below it
Suggestion
const dateToCompare = DateTime.fromISO(date);
if (!dateToCompare.isValid) return '';
const dateNow = DateTime.now();
const differenceInSeconds = dateNow.diff(dateToCompare).as('seconds');
return Math.abs(differenceInSeconds) >= 5
? dateToCompare.toRelative({ base: dateNow, locale: i18n.language })
: t('just now');
Agree / Disagree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implemented the logic to show 'Just now' instead of '0 seconds ago' when the difference is under one second.
Users can now see 'just now' when an edit happens.
Proposal
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description