♻️Bootstrap frontend #257
Merged
♻️Bootstrap frontend #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/bootstrap-frontend
branch
2 times, most recently
from
c80e7f3 to
6cac523
Compare
AntoLC
force-pushed
the
refacto/bootstrap-frontend
branch
from
6cac523 to
eac3b9c
Compare
AntoLC
force-pushed
the
refacto/bootstrap-frontend
branch
from
eac3b9c to
1539a24
Compare
AntoLC
force-pushed
the
refacto/bootstrap-frontend
branch
from
1539a24 to
1188566
Compare
The env MEDIA_URL was missing in the frontend Dockerfile. It is not necessary in our running environment (staging / preprod ...) but it is necessary if we want to run the frontend with a different media url. SW_DEACTIVATED was missing as well, we need to deactivate the service worker in the frontend when we test with Playwright.
We were providing a frontend development container to the developers, but it was not working properly. Problem of hot reload was present for Windows and Linux users. We stop to provide this development container and we will provide a container connected to the build of the frontend. You can still access the frontend after bootstrap on the "localhost:3000", but if you want to develop you will have to install the frontend dependencies localy and run the frontend in development mode. This will be more efficient and will avoid the problem of hot reload, and right on folder access.
With the new container available, we can simplify the workflow by removing the build step and using the container directly.
When we build the docker image, we get a warning about the casing in the Dockerfile. This commit fixes the casing in the Dockerfile.
AntoLC
force-pushed
the
refacto/bootstrap-frontend
branch
from
1188566 to
36f524f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We were providing a frontend development container to the developers, but it was not working properly.
Problem of hot reload was present for Windows and Linux users.
We stop to provide this development container and we will provide a container connected to the build of the frontend.
You can still access the frontend after bootstrap on the "localhost:3000", but if you want to develop you will have to install the frontend dependencies locally and run the frontend in development mode.
This will be more efficient and will avoid the problem of hot reload, and right on folder access.
Proposal