Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(frontend) More multi theme friendly #325

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Oct 11, 2024

Purpose

We adapt a bit the tokens of some components to be more multi theme friendly.
When we will add another theme, it will be easier to adapt to the new theme.

Proposal

  • 💄(frontend) components more multi theme friendly
  • ⚡️(frontend) use Marianne woff2 if compatible

@AntoLC AntoLC self-assigned this Oct 11, 2024
We adapt a bit the tokens of some components to be
more multi theme friendly.
When we will add another theme, it will be
easier to adapt to the new theme.
Woff2 is a more modern format for web fonts,
and it is supported by all modern browsers.
We still keep the woff format for
compatibility with older browsers.
@AntoLC AntoLC force-pushed the refacto/more-multi-theme-friendly branch from f47cd5d to d4d3de7 Compare October 11, 2024 12:57
@AntoLC AntoLC marked this pull request as ready for review October 11, 2024 13:25
@AntoLC AntoLC merged commit bc5dcb0 into main Oct 11, 2024
16 of 17 checks passed
@AntoLC AntoLC deleted the refacto/more-multi-theme-friendly branch October 11, 2024 13:26
@AntoLC AntoLC mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant