♻️(backend) fix access rights on the invitations API endpoint #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaccoud
added
bug
sampaccoud
changed the title
sampaccoud
force-pushed
the
fix-get-abilities
branch
3 times, most recently
from
5f809f3 to
878e4cc
Compare
qbey
reviewed
Oct 22, 2024
AntoLC
approved these changes
Oct 22, 2024
sampaccoud
force-pushed
the
fix-get-abilities
branch
from
878e4cc to
c636cdb
Compare
qbey
approved these changes
Oct 22, 2024
Only users who have the rights to manage accesses on the document should be allowed to see and manipulate invitations. Other users can see access rights on the document but only when the corresponding user/team has actually been granted access. We added a parameter in document abilities so the frontend knows when the logged-in user can invite another user with the owner role or not.
sampaccoud
force-pushed
the
fix-get-abilities
branch
from
c636cdb to
3762dcc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Only users who have the rights to manage accesses on a document should be allowed to see and manipulate invitations on this document.
Other users should be able to see access rights on the document but only when the corresponding user/team has actually been granted access, not during invitation.
Proposal
Refactor the invitation API endpoint to fix this issue concerning access rights on invitations.
As advised by @qbey, I took this refactoring opportunity to move any code related to permissions on invitations from the serializer to a permission class.
Tests on the invitation API endpoint were copied a bit too fast from https://github.com/numerique-gouv/people and did not respect the code style and testing strategy used in this project so I normalized them while modifying them to fix them following changes in the API code.