♻️(frontend) improve handleAIError #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/doc-ai-error
branch
3 times, most recently
from
bfbf295 to
3c98c65
Compare
PanchoutNathan
approved these changes
Oct 23, 2024
|
|
||
| useEffect(() => { | ||
| const languages = useMemo(() => { |
There was a problem hiding this comment.
No point in doing a useMemo here because it is not a heavy processing
There was a problem hiding this comment.
It is still doing a sorting on a dict of 100 elements.
Comment on lines
332
to
340
| const handleAIError = (error: unknown) => { | ||
| if (isAPIError(error)) { | ||
| if (error.status === 429) { | ||
| toast( | ||
| t('Too many requests. Please wait 60 seconds.'), | ||
| VariantType.ERROR, | ||
| ); | ||
|
|
||
| return; | ||
| } | ||
| } | ||
|
|
||
| toast(t('AI seems busy! Please try again.'), VariantType.ERROR); | ||
| console.error(error); | ||
| }, | ||
| [toast, t], | ||
| ); | ||
| toast(t('AI seems busy! Please try again.'), VariantType.ERROR); | ||
| console.error(error); | ||
| }; | ||
|
|
||
| return handleAIError; | ||
| }; |
There was a problem hiding this comment.
Do you authorize consoles.error?
You can simplify this hook :
const useHandleAIError = () => {
const { toast } = useToastProvider();
const { t } = useTranslation();
return (error: unknown) => {
if (isAPIError(error) && error.status === 429) {
toast(t('Too many requests. Please wait 60 seconds.'), VariantType.ERROR);
return;
}
toast(t('AI seems busy! Please try again.'), VariantType.ERROR);
};
};
Comment on lines
+296
to
+298
| if (!responseAI) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I'm not a big fan of this generic way. I would explain more because Depending on the type, it can only be a string and never undefined or null. So I would try a string
if (responseAI === '' ) {
return;
}
75c87bd to
306549c
Compare
To display the throttle error messages, we are doing a condition on the error message that we get from the backend. It is error prone because the backend error message are internationalized. This commit fixes this issue. It DRY the component as well.
Fix a flaky tests on the e2e test: - "it renders correctly when we switch from one doc to another" - "it saves the doc when we change pages"
AntoLC
force-pushed
the
fix/doc-ai-error
branch
from
306549c to
fde6283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To display the throttle error messages, we are doing a condition on the error message that we get from the backend.
It is error prone because the backend error message are internationalized.
It fixes partially this issue: #373