Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦺(backend) add comma to sub regex #408

Merged
merged 1 commit into from
Nov 8, 2024
Merged

🦺(backend) add comma to sub regex #408

merged 1 commit into from
Nov 8, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Nov 8, 2024

Purpose

Some sub have comma, the regex was a bit too strict and didn't allow it, this PR fixes that.

@AntoLC AntoLC self-assigned this Nov 8, 2024
@AntoLC AntoLC added the backend label Nov 8, 2024
@AntoLC AntoLC requested a review from sampaccoud November 8, 2024 09:15

dependencies = [
('core', '0008_alter_document_link_reach'),
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add a migration. This is not impacting the db schema, only validation in the Django code.

Some sub have comma, the regex was a bit too strict
and didn't allow it, this commit fixes that.
@AntoLC AntoLC enabled auto-merge (rebase) November 8, 2024 09:29
@AntoLC AntoLC merged commit 526e649 into main Nov 8, 2024
10 of 11 checks passed
@AntoLC AntoLC deleted the fix/regex-sub branch November 8, 2024 09:53
AntoLC added a commit that referenced this pull request Nov 25, 2024
Added:
- 🌐(backend) add german translation #259
- 🌐(frontend) Add German translation #255
- ✨(frontend) Add a broadcast store #387
- ✨(backend) whitelist pod's IP address #443
- ✨(backend) config endpoint #425
- ✨(frontend) config endpoint #424
- ✨(frontend) add sentry #424
- ✨(frontend) add crisp chatbot #450

Changed:
- 🚸(backend) improve users similarity search and
sort results #391
- ♻️(frontend) simplify stores #402
- ✨(frontend) update $css Box props type to add
styled components RuleSet #423

Fixed:
- 🔧(backend) fix logging for docker and make it
configurable by envar #427
- 🦺(backend) add comma to sub regex #408
- 🐛(editor) collaborative user tag hidden when
read only #385
- 🐛(frontend) users have view access when revoked #387
@AntoLC AntoLC mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants