💄(frontend) update doc export modal #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanchoutNathan
changed the title
AntoLC
reviewed
Nov 25, 2024
src/frontend/apps/impress/src/features/docs/doc-management/types.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeader.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Show resolved
Hide resolved
PanchoutNathan
force-pushed
the
main-new-ui
branch
from
6512013 to
1c84653
Compare
PanchoutNathan
force-pushed
the
new-ui/download-modal
branch
3 times, most recently
from
c7db486 to
325a7d5
Compare
AntoLC
reviewed
Nov 26, 2024
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeader.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
AntoLC
reviewed
Nov 26, 2024
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
AntoLC
reviewed
Nov 26, 2024
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
AntoLC
reviewed
Nov 26, 2024
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
AntoLC
approved these changes
Nov 26, 2024
PanchoutNathan
force-pushed
the
new-ui/download-modal
branch
from
325a7d5 to
268e37a
Compare
PanchoutNathan
force-pushed
the
main-new-ui
branch
from
1c84653 to
a1f20ec
Compare
We had already deleted this file but it must have reappeared with a bad rebase
Modification of the header style to be consistent with the new UI : - We replace the option menu with the DropdownMenu component - We add a dowload button - We put an input in place of an editable div.
Since we no longer use an editable div but an input, we must modify the tests accordingly
In the new interface, the export modal changes a little. - We put the buttons on the right - We remove the alert - We transform the radio into select
PanchoutNathan
force-pushed
the
new-ui/download-modal
branch
from
268e37a to
ae30e56
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the new interface, the export modal changes a little.