Mardown converter endpoint #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
pod-yjs-direct-auth
branch
from
0f9399b to
a109366
Compare
AntoLC
force-pushed
the
pod-yjs-direct-auth
branch
from
a109366 to
1e5976e
Compare
AntoLC
approved these changes
Dec 11, 2024
AntoLC
force-pushed
the
mardown-converter
branch
from
f1e39b7 to
afa0af9
Compare
lebaudantoine
force-pushed
the
mardown-converter
branch
3 times, most recently
from
f412e61 to
c0db9e7
Compare
Needed dependencies to mimic frontend code when generating a document from a markdown string. Will be used in the upcoming commits.
Add utility function to convert BitArray to Base64 string. This is required for creating Base64-encoded documents, as the frontend do.
This code is quite poor. Sorry, I don't have much time working on this feature. However, it should be functional. I've reused the code we created for the Demo with Kasbarian. I've not tested it yet with all corner case. Error handling might be improved for sure, same for logging. This endpoint is not modular. We could easily introduce options to modify its behavior based on some options. YAGNI I've added bearer token authentification, because it's unclear how this micro service would be exposed. It's totally not required if the microservice is not exposed through an Ingress.
lebaudantoine
force-pushed
the
mardown-converter
branch
from
c0db9e7 to
bdafd87
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow backend service to convert markdown content in yjs one using a nodejs microservice bootstrapped by @AntoLC for collaboration purpose.
Blocked by #472
Please check my commits;