Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(frontend) add pdf block to the editor #795

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dakshesh14
Copy link

Purpose

Added an option for users to upload and preview PDF files in the editor. This PR addresses #348.

feat-pdf-upload.mov

Proposal

Added the option for users to upload and preview PDF files within the editor.

Description:

  • When a user types '/' on their keyboard, they can find an option called "PDF," which allows them to upload or embed PDF files.
  • A fallback is provided for browsers that do not support the 'embed' tag.

Signed-off-by: dakshesh14 <dakshesh.jain14@gmail.com>
Signed-off-by: dakshesh14 <dakshesh.jain14@gmail.com>
Signed-off-by: dakshesh14 <dakshesh.jain14@gmail.com>
Signed-off-by: dakshesh14 <dakshesh.jain14@gmail.com>
Signed-off-by: dakshesh14 <dakshesh.jain14@gmail.com>
@dakshesh14
Copy link
Author

Hey team, this is my first PR in the repo, and I <3 the project! I think there are a couple of areas that we could be improved in my PR and, I would love the maintainers' input on:

  1. Using react-pdf or another library for better PDF preview compatibility and UX.
  2. Changing the nginx config might not be acceptable, so I’m open to discussing alternatives.

Please let me know if I should look into these or if there are any other comments or suggestions. Once again, I love the project!

@lunika lunika requested review from AntoLC and lunika March 23, 2025 18:15
@AntoLC
Copy link
Collaborator

AntoLC commented Mar 24, 2025

Hi, thank you for this nice PR!
I will catch some time this week to look at it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants