Sourcery refactored main branch

[sourcery-ai]

Branch main refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch origin sourcery/main
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.04%.

Quality metrics	Before	After	Change
Complexity	1.58 ⭐	1.58 ⭐	0.00
Method Length	82.90 🙂	82.69 🙂	-0.21 👍
Working memory	6.34 🙂	6.34 🙂	0.00
Quality	75.80% ⭐	75.84% ⭐	0.04% 👍

Other metrics	Before	After	Change
Lines	1262	1262	0

Changed files	Quality Before	Quality After	Quality Change
octodns_netbox/init.py	69.88% 🙂	69.90% 🙂	0.02% 👍
octodns_netbox/reversename.py	77.33% ⭐	77.67% ⭐	0.34% 👍
tests/test_octodns_netbox.py	77.27% ⭐	77.28% ⭐	0.01% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
octodns_netbox/init.py	NetboxSource._populate_normal	8 ⭐	140 😞	9 🙂	58.22% 🙂	Try splitting into smaller methods
octodns_netbox/init.py	NetboxSource._populate_PTR	5 ⭐	147 😞	9 🙂	60.34% 🙂	Try splitting into smaller methods
tests/test_octodns_netbox.py	TestNetboxSourcePopulateNormal.test_populate_A_and_AAAA	1 ⭐	179 😞	7 🙂	65.74% 🙂	Try splitting into smaller methods
tests/test_octodns_netbox.py	TestNetboxSourcePopulateNormal.test_populate_A_and_AAAA_field_is_dns_name	1 ⭐	152 😞	7 🙂	68.33% 🙂	Try splitting into smaller methods
tests/test_octodns_netbox.py	TestNetboxSourcePopulateNormal.test_populate_A_and_AAAA_field_is_dns_name_populate_subdomains_is_False	1 ⭐	135 😞	7 🙂	70.20% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codeclimate]

Code Climate has analyzed commit 0e675d6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.