Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'poetry install' step before building #83

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mochipon
Copy link
Contributor

@mochipon mochipon commented Jan 20, 2025

Summary by Sourcery

CI:

  • Install project dependencies using poetry install.

Copy link

sourcery-ai bot commented Jan 20, 2025

Reviewer's Guide by Sourcery

This pull request adds the missing 'poetry install' step to the CI and release workflows. This ensures that all dependencies are installed before building the project.

Sequence diagram for updated CI/Release workflow steps

sequenceDiagram
    participant CI as CI/Release Workflow
    participant Poetry as Poetry Package Manager
    participant Pip as Pip
    CI->>Pip: Upgrade pip
    CI->>Pip: Install poetry
    CI->>Poetry: Install project dependencies (new step)
    Note right of Poetry: Added missing 'poetry install' step
    CI->>Poetry: Build wheels and source tarball
Loading

File-Level Changes

Change Details Files
Added 'poetry install' step to CI workflow.
  • Added 'poetry install' command after installing poetry.
.github/workflows/ci.yml
Added 'poetry install' step to release workflow.
  • Added 'poetry install' command after installing poetry.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@mochipon mochipon merged commit 9d42333 into main Jan 20, 2025
6 checks passed
@mochipon mochipon deleted the fix/poetry_install branch January 20, 2025 11:05
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mochipon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant