Optional support for multi-value PTRs #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-value PTR records is indeed supported by octoDNS.
The problem is if unsupported providers (e.g., PowerDNS, Google Cloud DNS) are used. In a backward compatible way, octoDNS will leave only one value.
https://github.com/octodns/octodns/blob/6890e3307c7246720820e4dc8f18edc2c8bcf164/octodns/provider/base.py#L91-L102
However, we cannot choose which to keep. The current implementation seems to keep the first value sorted by name, but this may not be what the user actually wants.
For instance, I might type
v1001.rtr.example.com,rtr.example.com
in the description field. In this case,rtr.example.com
will always be selected, but is this the desired result for the operator?