-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gesture preview crash on macOS 12 #4
base: master
Are you sure you want to change the base?
Conversation
[NSView lockFocus] was deprecated in macOS 10.14 and seems to be removed on 12.0 http://codeworkshop.net/objc-diff/sdkdiffs/macos/10.14/AppKit.html A static background color is a viable substitute, though not as pretty.
As much as I appreciate @sukolsak's original work on Jitouch, I don't think he's interested in maintaining this project any more, because Jitouch haven't received a single update on its official website for almost three years and this github repo doesn't look active neither. @aaronkollasch Could you please consider taking on the work and releasing compiled artifacts in you own repo? Thanks. |
@we11adam I'll consider it if I have time. However, I don't have an Apple Developer signing certificate and I'm not sure it will be worth the expense. There is the message on the website when clicking on the free license key that says:
@sukolsak @supasorn are you still planning on releasing jitouch 3.0? |
Ok @we11adam, given I haven't heard from the original authors I've released compiled artifacts: |
@aaronkollasch Hi Aaron, thanks for actively maintaining the forked version. 2.79 works great on my MacBook. Really appreciate it! |
Just wanted to let you know that stuff's going on behind the scenes, and there will indeed be a new release coming up. I've already involved Aaron to merge his changes, but my work isn't quite ready yet. So keep your eyes peeled and use Aaron's build for the time being! |
@Crazor Hi, care to share some progress here? I'm not being pushy, just really curious. Take your time. Thank you! :) |
[NSView lockFocus]
was deprecated in macOS 10.14 and seems to be removed on 12.0.This PR prevents the prefpane from crashing while trying to show the gesture preview window. It uses a single background color as a substitute for a drawn background, though it is not as pretty.
imageWithSize:flipped:drawingHandler
is a potential replacement forlockFocus
, e.g.(Sorry for the several pull requests. I could merge them into an M1+macOS 12 PR, but they seemed like separate issues. Just submitting in case they are helpful to anyone else.)