This repository has been archived by the owner on May 11, 2022. It is now read-only.

Memoize the fedora client certificate store to avoid unnecessary reinitialization #274

Merged

drh-stanford merged 1 commit into master from custom-cert-store

Nov 18, 2016

Contributor

cbeer commented Nov 17, 2016 •

edited

Loading

Depends on samvera/active_fedora#1176

Fixes sul-dlss-deprecated/dor_indexing_app#109.

coveralls commented Nov 17, 2016 •

edited

Loading

Coverage decreased (-0.05%) to 89.68% when pulling 1047333 on custom-cert-store into 2d7e982 on master.

1 similar comment

coveralls commented Nov 17, 2016 •

edited

Loading

Coverage decreased (-0.05%) to 89.68% when pulling 1047333 on custom-cert-store into 2d7e982 on master.

drh-stanford reviewed

View reviewed changes

lib/dor/config.rb

@@ @@ -131,6 +131,7 @@ def fedora_config @@
                     connection_opts = { :url => fedora.safeurl, :user => fedora_uri.user, :password => fedora_uri.password }
                     connection_opts[:ssl_client_cert] = OpenSSL::X509::Certificate.new(File.read(ssl.cert_file)) if ssl.cert_file.present?
                     connection_opts[:ssl_client_key] = OpenSSL::PKey::RSA.new(File.read(ssl.key_file), ssl.key_pass) if ssl.key_file.present?
+                    connection_opts[:cert_store] = default_ssl_cert_store

drh-stanford Nov 18, 2016

shouldn't this be :ssl_cert_store? see https://github.com/rest-client/rest-client/blob/adb990bd54596c76d5fa74d7f6d52d23e0cad321/lib/restclient/request.rb#L179-L184

Contributor Author

cbeer Nov 18, 2016

Good catch. I misread https://github.com/rest-client/rest-client/blob/adb990bd54596c76d5fa74d7f6d52d23e0cad321/lib/restclient/request.rb#L190.


          Memoize the fedora client certificate store to avoid unnecessary rein…

8f7e277

…itialization

cbeer force-pushed the custom-cert-store branch from 1047333 to 8f7e277 Compare

November 18, 2016 18:26

drh-stanford merged commit d8d32e5 into master

drh-stanford deleted the custom-cert-store branch

November 18, 2016 18:36

coveralls commented Nov 18, 2016 •

edited

Loading

Coverage decreased (-0.05%) to 89.686% when pulling 8f7e277 on custom-cert-store into f52ba3a on master.

4 similar comments

coveralls commented Nov 18, 2016

Coverage decreased (-0.05%) to 89.686% when pulling 8f7e277 on custom-cert-store into f52ba3a on master.

coveralls commented Nov 18, 2016

Coverage decreased (-0.05%) to 89.686% when pulling 8f7e277 on custom-cert-store into f52ba3a on master.

coveralls commented Nov 18, 2016

Coverage decreased (-0.05%) to 89.686% when pulling 8f7e277 on custom-cert-store into f52ba3a on master.

coveralls commented Nov 18, 2016

Coverage decreased (-0.05%) to 89.686% when pulling 8f7e277 on custom-cert-store into f52ba3a on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet