Skip to content
This repository has been archived by the owner on Mar 14, 2022. It is now read-only.

Persist a record in the repository #109

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Persist a record in the repository #109

merged 1 commit into from
Jan 31, 2018

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 29, 2018 •
edited
Loading

Fixes #99
Fixes #110

@jcoyne jcoyne added the review label Jan 29, 2018
@jcoyne jcoyne force-pushed the persistence branch 2 times, most recently from 4a203da to 2e64303 Compare January 30, 2018 14:55
@jcoyne jcoyne changed the title [WIP] Persist a record in the repository Persist a record in the repository Jan 30, 2018
jcoyne
jcoyne commented Jan 30, 2018
View reviewed changes
README.md
### To run the API code

```shell
$ go run main.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already exists on line 34, so removing.

@jcoyne jcoyne force-pushed the persistence branch 13 times, most recently from 7784b66 to 0877a9e Compare January 30, 2018 22:30
eefahy
eefahy reviewed Jan 31, 2018
View reviewed changes
.circleci/config.yml
name: Install AWS CLI
command: |
sudo apt-get -y -qq update
sudo apt-get -y -qq install awscli
Copy link
Contributor

@eefahy eefahy Jan 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an old version of the awscli that will prob bite you down the road. The preferred way to install it is in the deploy_to_dev job below. This can get changed later though, so not blocking this PR for that change

@eefahy
Copy link
Contributor

eefahy commented Jan 31, 2018

One question I have is if we want to have all resources in a single resources table or if we want to have a different table for each resource type

@eefahy eefahy merged commit 59e3a85 into master Jan 31, 2018
@eefahy eefahy deleted the persistence branch January 31, 2018 01:08
@eefahy eefahy removed the review label Jan 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eefahy eefahy eefahy approved these changes

@aaron-collier aaron-collier aaron-collier approved these changes

@cmharlow cmharlow Awaiting requested review from cmharlow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcoyne @eefahy @aaron-collier