-
Notifications
You must be signed in to change notification settings - Fork 7
Update README.md to use dep ensure rather than go get #134
Conversation
@@ -45,7 +45,7 @@ $ docker run -p 8080:8080 taco | |||
### Build for the local OS | |||
```shell | |||
% cd cmd/tacod | |||
% go get -t | |||
% dep ensure -vendor-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the -vendor-only
flag necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, otherwise it’ll recalculate the dependencies rather than use what we have tested locally, which is specified by the lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is exactly the opposite of what we've been working through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmh2166 yes I have done #94. I think that dep ensure -vendor-only
is what we want someone who is newly pulling our code (and wanting to get something guaranteed to work) is going to want to do. In this way they get exactly what is in the Gopkg.lock that we know is working. If they do dep ensure
it may update the lock file, causing the user to be running on libraries we haven't tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some evidence of why dep ensure
gives a user a version that is not the same as what we've developed on: #151. If you do dep ensure -vendor-only
it doesn't make these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by #94.
Fixes #111