Skip to content
This repository has been archived by the owner on Mar 14, 2022. It is now read-only.

Update README.md to use dep ensure rather than go get #134

Closed
wants to merge 1 commit into from
Closed

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 30, 2018

Fixes #111

@jcoyne jcoyne added the review label Jan 30, 2018
@@ -45,7 +45,7 @@ $ docker run -p 8080:8080 taco
### Build for the local OS
```shell
% cd cmd/tacod
% go get -t
% dep ensure -vendor-only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the -vendor-only flag necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise it’ll recalculate the dependencies rather than use what we have tested locally, which is specified by the lock file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is exactly the opposite of what we've been working through.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justin, have you done #94 yet? I think the rest of the group has - and I don't know if what issues you are having due to your setup are occurring for others. I'd say close this PR until you've gone through #94 and we have some more concrete, shared knowledge on usage of dep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmh2166 yes I have done #94. I think that dep ensure -vendor-only is what we want someone who is newly pulling our code (and wanting to get something guaranteed to work) is going to want to do. In this way they get exactly what is in the Gopkg.lock that we know is working. If they do dep ensure it may update the lock file, causing the user to be running on libraries we haven't tested.

Copy link
Contributor Author

@jcoyne jcoyne Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some evidence of why dep ensure gives a user a version that is not the same as what we've developed on: #151. If you do dep ensure -vendor-only it doesn't make these changes.

Copy link
Contributor

@cmharlow cmharlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by #94.

@jcoyne jcoyne closed this Feb 6, 2018
@jcoyne jcoyne deleted the dep branch February 6, 2018 20:23
@jcoyne jcoyne removed the review label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants