-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
"example" : "0a72c00a-1332-4730-b19c-9131c3bcb57f" | ||
} | ||
} | ||
"$ref" : "#/definitions/Resource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree that this is the correct response for a create. As documented on the whiteboard the response should be a RequestID, a ResourceID and a RequestStatus. I don't think it makes sense to send them back the resource they just sent us. See #44
I'm curious to know what you mean about the UUID library being missing. I see it in the lockfile right here: https://github.com/sul-dlss-labs/taco/blob/master/Gopkg.lock#L156-L159 |
It wasn’t in the toml file for me to then ensure off of. Can confirm again when at a computer.
…On Jan 25, 2018, 8:49 PM -0800, Justin Coyne ***@***.***>, wrote:
I'm curious to know what you mean about the UUID library being missing. I see it in the lockfile right here: https://github.com/sul-dlss-labs/taco/blob/master/Gopkg.lock#L156-L159
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@cmh2166 are we certain it needs to be in the toml file? I thought that was just for the ones it can't introspect. The true list of dependencies is in the .lock file. |
Check the docs around |
@cmh2166 yeah on that page I'm seeing:
So I'm wondering what the drawback to this approach is. This also seems to be what one of the maintainers recommends as her preferred workflow: golang/dep#376 (comment) |
@jcoyne i'm not commenting on the approach against, i'm saying we don't do that cleanly right now (hence your original PR adding all this dynamo stuff not working when I pulled down and only ran Regardless, that is ticketed and does not stop this PR. |
Closing ticket given recent updates. Doesn't close issues related since those are still undetermined (and the code / spec still need cleaning up). |
Regenerating API code to work. Removed status from Resource model, since status isn't yet determined as something the API code needs to be aware of.
Dependencies (UUID library) are missing from this PR (are getting put into $GOPATH via
go get
and not intodep ensure
) that need to be documented and added. We also have a dep / aws-sdk for go conflict. Opened issues #75 #74 for these, respectively.